Fix Github Actions and use PropEr github revision#224
Merged
alfert merged 15 commits intoalfert:masterfrom Nov 28, 2023
Merged
Conversation
Closed
evnu
force-pushed
the
fix-ci
branch
3 times, most recently
from
aeb6889 to
0f833c0
Compare
Coverage is quite low, and tracing slows down the tests. Coverage should be handled again, but only for a single runner and not in the matrix itself.
This resolves this error:
** (UndefinedFunctionError) function Dialyxir.Output.info/1 is undefined (module Dialyxir.Output is not available)
(dialyxir 1.4.1) Dialyxir.Output.info("Finding suitable PLTs")
(dialyxir 1.4.1) lib/mix/tasks/dialyzer.ex:174: Mix.Tasks.Dialyzer.run/1
(mix 1.15.6) lib/mix/task.ex:447: anonymous fn/3 in Mix.Task.run_task/5
(mix 1.15.6) lib/mix/task.ex:506: Mix.Task.run_alias/6
(mix 1.15.6) lib/mix/cli.ex:92: Mix.CLI.run_task/2
/usr/bin/mix:2: (file)
[1] 104215 exit 1 mix lint
evnu
changed the title
Collaborator
Author
|
@alfert can you take a look into the branch protection rules, something is amiss here w.r.t. naming of the jobs. That' might be why the obsolete old jobs are still listed here. See https://github.com/orgs/community/discussions/25720 |
Collaborator
Author
|
@alfert ping; how should we proceed here? |
|
These changes look great. I love that #217 is resolved. I'm going to use your branch until this is resolved. |
Owner
|
Hey @evnu, sorry for being so long in stasis. I deleted all the branch protection rules for Elixir 1.7 to 1.11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does multiple things to fix github actions:
will_failMix.ConfigLogger.warninginstead ofLogger.warnEnum.filter() |> Enum.count(),apply/3andEnum.map_join/3Fix #217