Remove broken bind/append functions #72
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be a little controversial. I noticed this after seeing @MichaelXavier issue #71.
Basically when using
bind
forHtml
it creates an array instead of a newElement
value. This then falls through on theFunctor
instance here. It would also, I'm fairly sure, break if it was the top-level Html (not tested though).The alternative to this PR is having to add/maintain support for
Html
being either anElement
,Class
and an array ofHtml
. I would argue this is just going to make it harder to support and increase the number of edge cases.The downside which this PR is that you can no longer use the
do
syntax forHtml
, which is certainly nice to use, but I would argue better than increasing the complexity of the pux internals.Thoughts?