Export a type alias for the core set of Pux effects #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype alias. When an app developer writes their own effects type alias, eg. type AppEffects eff = (log :: CONSOLE | eff) ... This allows two things: * `main` to have a type using `(CoreEffects (AppEffects eff))`. * Individual `update` functions to, if the shortcut is appropriate, have *only* `(AppEffects eff)`, to avoid the common problem where PureScript complains about getting two instances of `channel` or `exception` if an `update` function is declared with either.
|
I honestly can't figure out what the build error is. Even following the "This log is too long to be displayed. Please reduce the verbosity of your build or download the raw log" instructions to see the raw log, I can't get to the end of the list. |
|
Thanks for this! I like it. Don't worry about the test, Travis is really weird with purescript for a number of reasons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(For the sake of reuse and convenience.)
When an app developer writes their own app effects type alias, eg.
... This allows two things:
mainto have a type using(CoreEffects (AppEffects eff)).updatefunctions to, if the shortcut is appropriate, have only(AppEffects eff), to avoid the common problem where PureScript complains about getting two instances ofchannelorexceptionif anupdatefunction is declared with either.(I mention only having one App effect-set above, but in reality I'd have a few finer-grained aliases.)