Skip to content

[MacOS] Process stuck, when trying to use ripgrep-js #174

@danylooop

Description

@danylooop

Hello!

Thx for your lib and your work.

I've noticed, that when I'm trying to use it on my M1 MacOS 11.6 with node 12/14/16 I have a stuck process.
As I found, ripgrep project has this bug/feature BurntSushi/ripgrep#410
From this comment BurntSushi/ripgrep#410 (comment):

ripgrep expects that you will pass files to search via stdin and so, the child process waits until we send input to it, but we don't. The author of ripgrep suggested to specify working directory using -- files/to/search

Author of the original issue to ripgrep also made changes according to received suggestion microsoft/vscode@ac420a2

I've tried to do same in your lib and that's fixed my problem. So, if you are not against it, maybe we can merge my PR (will make it soon)?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions