Syntax fix #8
Merged
Syntax fix #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I find the tests to run inconsistently (even locally, on the current master). Did you notice that already? It seems to be related to the Web Components to be rendered too late for the test suite under some circumstances... |
|
Hmm, interesting. I'm sure that's related to the other PR failing the build as well. I haven't noticed flakey tests in the past, but I'll check it out. We may need to add a test helper that slows the tests down until whatever is available if it seems like it could be a timing issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.reduce(...)requires a default value.