Skip to content
This repository was archived by the owner on May 14, 2020. It is now read-only.
This repository was archived by the owner on May 14, 2020. It is now read-only.

Does not correctly handle immutable objects when hideRoot is false #34

Closed
@leonaves

Description

@leonaves

Issue is here: https://github.com/chibicode/react-json-tree/blob/master/src/index.js#L81-L105

The getChildNodes function does not consider if the object of type immutable and breaks the detection in obj-type.js. An easy fix would be an if objType(value) === 'Iterable' somewhere in that function but I haven't submitted a PR because I have a feeling you'd want it done a bit more carefully.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions