Skip to content

Commit

Permalink
fix: Fixed virtual or overridden RPC methods
Browse files Browse the repository at this point in the history
  • Loading branch information
TwoTenPvP committed Aug 12, 2019
1 parent c5fd679 commit 15f55dd
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions MLAPI/Messaging/RpcTypeDefinition.cs
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,21 @@ private RpcTypeDefinition(Type type)

Dictionary<ulong, ReflectionMethod> lookupTarget = rpcMethod.serverTarget ? serverMethods : clientMethods;

lookupTarget.Add(HashMethodNameAndValidate(method.Name), rpcMethod);
ulong nameHash = HashMethodNameAndValidate(method.Name);

if (!lookupTarget.ContainsKey(nameHash))
{
lookupTarget.Add(nameHash, rpcMethod);
}

if (parameters.Length > 0)
{
lookupTarget.Add(HashMethodNameAndValidate(NetworkedBehaviour.GetHashableMethodSignature(method)), rpcMethod);
ulong signatureHash = HashMethodNameAndValidate(NetworkedBehaviour.GetHashableMethodSignature(method));

if (!lookupTarget.ContainsKey(signatureHash))
{
lookupTarget.Add(signatureHash, rpcMethod);
}
}

if (rpcMethod.useDelegate)
Expand Down

0 comments on commit 15f55dd

Please sign in to comment.