Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instruction for pip in the README #230

Merged
merged 3 commits into from
Aug 31, 2024
Merged

Add instruction for pip in the README #230

merged 3 commits into from
Aug 31, 2024

Conversation

wiseodd
Copy link
Collaborator

@wiseodd wiseodd commented Aug 21, 2024

Self-explanatory!

@wiseodd wiseodd added the documentation Improvements or additions to documentation label Aug 21, 2024
@wiseodd wiseodd self-assigned this Aug 21, 2024
runame
runame approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@runame runame left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests are failing though.

@wiseodd
Copy link
Collaborator Author

wiseodd commented Aug 21, 2024

Thanks!

@Ludvins could you please take a look at the tests? It's from test_functional_laplace_units.py.

@aleximmer
Copy link
Owner

Thanks. Tests are passing now and this change is important, otherwise uv does not work for dev setup.

@aleximmer aleximmer merged commit 84d8d07 into main Aug 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runame runame runame approved these changes

@aleximmer aleximmer Awaiting requested review from aleximmer

Assignees

@wiseodd wiseodd

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wiseodd @aleximmer @runame