Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some checks in optimize_prior_precision #205

Merged
merged 3 commits into from
Jul 7, 2024
Merged

Add some checks in optimize_prior_precision #205

merged 3 commits into from
Jul 7, 2024

Conversation

wiseodd
Copy link
Collaborator

@wiseodd wiseodd commented Jul 7, 2024

Closes #103.

Add some checks in optimize_prior_precision, and notify users in README.

@runame please review. Feel free to suggest further checks.

@wiseodd wiseodd added the documentation Improvements or additions to documentation label Jul 7, 2024
@wiseodd wiseodd added this to the 0.2 milestone Jul 7, 2024
@wiseodd wiseodd requested a review from runame July 7, 2024 16:01
@wiseodd wiseodd self-assigned this Jul 7, 2024
@wiseodd
Copy link
Collaborator Author

wiseodd commented Jul 7, 2024

Please ignore the failed pytest. It's due to curvlinops and fixed in #202

Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my comment, LGTM

README.md Outdated Show resolved Hide resolved
@wiseodd wiseodd merged commit 0fdc973 into main Jul 7, 2024
3 checks passed
@wiseodd wiseodd deleted the check-tuning branch July 7, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add check for optimize_prior_precision() arguments
2 participants