Functional Laplace Updated #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiseodd
requested changes
Jun 23, 2024
laplace/utils/utils.py
Outdated
Comment on lines
225
to
226
| np.random.seed(seed) | ||
| self.indices = torch.tensor(np.random.choice(list(range(N)), M, replace=False)) |
There was a problem hiding this comment.
I see. The main issue for me is that it changes the global rng state. Can you use Numpy's generator?
|
Thanks for the changes! The code looks good now and passes all checks. Only small bits of changes needed this time. |
|
@aleximmer please review if you have chance. |
Closed
|
I've created two functions
This can be moved as an utils function but it might be usefull in BaseLaplace too. |
wiseodd
approved these changes
Jun 27, 2024
aleximmer
reviewed
Jul 8, 2024
Closed
aleximmer
reviewed
Jul 12, 2024
aleximmer
reviewed
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took @metodmove's contribution from PR 55 and adapted it to the current state of the repository.
Functional Laplace can be used with
hessian='gp', there is an example at calibration_gp_example.py and calibration_gp_example.md.Two unit-tests are available: test_functional_laplace.py and test_functional_laplace_unit.py.