-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running metrics #135
Running metrics #135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides my minor comment, LGTM! Can you check how many tests failed? Only 7 should fail and they all should be related to LowRankLaplace
(since this hasn't been implemented for the new ASDL version yet).
@runame please check again! |
LGTM, have you checked the tests? |
Updated the test! @runame |
Support running metrics in cross validation of prior precision. Rationale: gathering data then computing metric is very expensive if
n_data
is very large.There are some failed tests for LLLaplace, but I think they are unrelated.