Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KronDecomposed.diag() feature #121

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Add KronDecomposed.diag() feature #121

merged 2 commits into from
Mar 22, 2023

Conversation

aleximmer
Copy link
Owner

Small utility feature to get per-weight diagonal posterior precision when using KronLaplace.

@aleximmer aleximmer requested a review from runame March 22, 2023 13:10
runame
runame approved these changes Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

laplace/utils/matrix.py Outdated Show resolved Hide resolved
laplace/utils/matrix.py Outdated Show resolved Hide resolved
@runame runame added the enhancement New feature or request label Mar 22, 2023
@aleximmer
Copy link
Owner Author

Thanks, replaced all ger() in the file, there were a few more.

@aleximmer aleximmer merged commit ada1c6f into main Mar 22, 2023
@aleximmer aleximmer deleted the precision-diag branch March 22, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runame runame runame approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleximmer @runame