Skip to content

Commit

Permalink
[GSYM] Remove redundant getInliningInfoForAddress call (llvm#111136)
Browse files Browse the repository at this point in the history
In DwarfTransformer::verify() line number information is retrieved for
each address using:

  auto DwarfInlineInfos =
      DICtx.getInliningInfoForAddress(SectAddr, DLIS);

Later down the loop, another such invocation was made before:

  Gsym->dump(Log, *FI);

There is a continue after that, DwarfInlineInfos do not affect the
dump() invocation, I am not aware of any other side effects that is
needed from the extra getInliningInfoForAddress() invocation, and tests
pass without it, so just remove it.
  • Loading branch information
dstenb authored Oct 15, 2024
1 parent 5f2cf99 commit 97da5e6
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion llvm/lib/DebugInfo/GSYM/DwarfTransformer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,6 @@ llvm::Error DwarfTransformer::verify(StringRef GsymPath,
Log << " [" << Idx << "]: " << gii.Name << " @ " << gii.Dir
<< '/' << gii.Base << ':' << gii.Line << '\n';
}
DwarfInlineInfos = DICtx.getInliningInfoForAddress(SectAddr, DLIS);
Gsym->dump(Log, *FI);
}
continue;
Expand Down

0 comments on commit 97da5e6

Please sign in to comment.