Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Label and message for PRs with Merge Commits #151

Open
Waterdrips opened this issue Apr 3, 2020 · 2 comments
Open

Proposal: Label and message for PRs with Merge Commits #151

Waterdrips opened this issue Apr 3, 2020 · 2 comments

Comments

@Waterdrips
Copy link
Contributor

If there's a merge commit pushed to a PR can we add a label and post a message to the PR from Derek saying that Merge Commits are not allowed, and provide info on how to remove it, and rebase.

Can we detect easily merge commits? Is it the format of the commit message or are they different?

Expected Behaviour

A PR with a merge commit pushed to it should get a label from derek and a message posted about why and how to fix it.
2 scenarios

  1. A PR is raised and there is already a merge commit
  2. A Merge Commit is pushed to the PR

Should this be optional? Configured in the yaml? What about for repos that dont have the config set? Do we enable or disable by default?

Current Behaviour

No feature

Possible Solution

Add a check into Derek that fulfils the 2x scenarios if enabled.

@alexellis
Copy link
Owner

Thanks for the suggestion, this seems like it could be automated and save us some time explaining the same thing over and over. Are you wanting to work on this @Waterdrips?

@Waterdrips
Copy link
Contributor Author

I am interested in doing this, but I have quite a lot of WIP so I'd rather not pick it up and block someone else from doing this if they wanted.

When I have my WIP down to a more manageable level I'll come back and see if this is still unassigned and take it on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants