Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support tilt since 0.22.15 #1010

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

sgtoj
Copy link
Contributor

@sgtoj sgtoj commented Jan 4, 2024

Description

#1009 - Minor update to remove the out dated suffix of _ALPHA for tilt when installing on ARM.

Motivation and Context

  • I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required)

How Has This Been Tested?

make test

If updating or adding a new CLI to arkade get, run:

go build && ./hack/test-tool.sh tilt

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

Copy link

derek bot commented Jan 4, 2024

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "you@domain.com"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

@sgtoj
Copy link
Contributor Author

sgtoj commented Jan 4, 2024

Output for ./hack/test-tool.sh

+ ./arkade get tilt --arch arm64 --os darwin --quiet
+ file /Users/brian/.arkade/bin/tilt
/Users/brian/.arkade/bin/tilt: Mach-O 64-bit executable x86_64
+ rm /Users/brian/.arkade/bin/tilt
+ echo

+ ./arkade get tilt --arch x86_64 --os darwin --quiet
+ file /Users/brian/.arkade/bin/tilt
/Users/brian/.arkade/bin/tilt: Mach-O 64-bit executable x86_64
+ rm /Users/brian/.arkade/bin/tilt
+ echo

+ ./arkade get tilt --arch x86_64 --os linux --quiet
+ file /Users/brian/.arkade/bin/tilt
/Users/brian/.arkade/bin/tilt: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, BuildID[sha1]=00faf54f3aa1a26f966d027921512ef8a6e71156, for GNU/Linux 3.2.0, stripped
+ rm /Users/brian/.arkade/bin/tilt
+ echo

+ ./arkade get tilt --arch aarch64 --os linux --quiet
+ file /Users/brian/.arkade/bin/tilt
/Users/brian/.arkade/bin/tilt: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, Go BuildID=5-F9CBcRhjlrErxbHipA/208amWVCzRf9QYm9Xw5O/D_cs7mDqfYrHF-p2N_J5/9ZDXoxYzZd-JEmN6TM68, BuildID[sha1]=804dc4ac4489922e015ce1cf4dff61a0c18c8ec5, stripped
+ rm /Users/brian/.arkade/bin/tilt
+ echo

+ ./arkade get tilt --arch x86_64 --os mingw --quiet
+ file /Users/brian/.arkade/bin/tilt.exe
/Users/brian/.arkade/bin/tilt.exe: PE32+ executable (console) x86-64 (stripped to external PDB), for MS Windows
+ rm /Users/brian/.arkade/bin/tilt.exe
+ echo

Signed-off-by: Brian Ojeda <brian@recurforever.com>
@derek derek bot removed the no-dco label Jan 4, 2024
@sgtoj sgtoj changed the title feat: support tilt since 0.33.15 feat: support tilt since 0.22.15 Jan 17, 2024
Copy link
Contributor

@Shikachuu Shikachuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine and necessary, thanks for the PR!

@sgtoj
Copy link
Contributor Author

sgtoj commented Feb 15, 2024

What are the next steps for this PR?

Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 205dbac into alexellis:master Feb 16, 2024
@alexellis
Copy link
Owner

Hi @sgtoj I work on open source as a spare time thing, and because my number of GitHub Sponsors has tanked massively, I am unable to dedicated as much time as they need.

If we all want to make this better, I'd encourage folks to read the notes in the README about how to support arkade.

Separately, thanks again for the PR, even if it took me a while to get to it.

Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants