Update tool defintion for viddy

Breaking changes detected via e2e tests and fixed Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
alexellis · Aug 27, 2024 · 34ca06f · 34ca06f
1 parent 568ded2
commit 34ca06f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 11 deletions.
diff --git a/pkg/get/get_test.go b/pkg/get/get_test.go
@@ -5629,31 +5629,31 @@ func Test_DownloadViddy(t *testing.T) {
 			os:      "darwin",
 			arch:    arch64bit,
 			version: version,
-			url:     "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy_Darwin_x86_64.tar.gz",
+			url:     "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy-v0.3.6-macos-x86_64.tar.gz",
 		},
 		{
 			os:      "darwin",
 			arch:    archDarwinARM64,
 			version: version,
-			url:     "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy_Darwin_arm64.tar.gz",
+			url:     "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy-v0.3.6-macos-arm64.tar.gz",
 		},
 		{
 			os:      "linux",
 			arch:    arch64bit,
 			version: version,
-			url:     "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy_Linux_x86_64.tar.gz",
+			url:     "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy-v0.3.6-linux-x86_64.tar.gz",
 		},
 		{
 			os:      "linux",
 			arch:    archARM64,
 			version: version,
-			url:     "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy_Linux_arm64.tar.gz",
+			url:     "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy-v0.3.6-linux-arm64.tar.gz",
 		},
 		{
 			os:      "ming",
 			arch:    arch64bit,
 			version: version,
-			url:     "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy_Windows_x86_64.tar.gz",
+			url:     "https://github.com/sachaos/viddy/releases/download/v0.3.6/viddy-v0.3.6-windows-x86_64.tar.gz",
 		},
 	}
 

diff --git a/pkg/get/tools.go b/pkg/get/tools.go
@@ -3167,16 +3167,14 @@ https://github.com/{{.Owner}}/{{.Repo}}/releases/download/{{.Version}}/{{.Name}}
 					{{$arch = "arm64"}}
 					{{- end -}}
 
-					{{$osStr := ""}}
+					{{$osStr := .OS}}
 					{{ if HasPrefix .OS "ming" -}}
-						{{$osStr = "Windows"}}
-					{{- else if eq .OS "linux" -}}
-						{{$osStr = "Linux"}}
+						{{$osStr = "windows"}}
 					{{- else if eq .OS "darwin" -}}
-						{{$osStr = "Darwin"}}
+						{{$osStr = "macos"}}
 					{{- end -}}
 
-					{{.Name}}_{{$osStr}}_{{$arch}}.{{$ext}}
+					{{.Name}}-{{.Version}}-{{$osStr}}-{{$arch}}.{{$ext}}
 					`,
 		})