Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests code improvements #219

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Tests code improvements #219

wants to merge 2 commits into from

Conversation

rastorc3v
Copy link

@rastorc3v rastorc3v commented Feb 2, 2023

  • var replaced with const

  • anonymous functions replaced with arrow functions

  • PI value replaced with Math.PI constant

  • equal replaced with strictEqual since the first one was deprecated

  • tests

  • linter

@msimerson
Copy link
Contributor

equal replaced with strictEqual since the first one was deprecated

The better way to do this is by loading assert like this: const assert = require('assert/strict'), or if we're willing to drop support for older versions of node: const assert = require('node:assert/strict').

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants