Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot extend editor.ui.view template #5

Closed
alexeckermann opened this issue Jul 6, 2018 · 5 comments
Closed

Cannot extend editor.ui.view template #5

alexeckermann opened this issue Jul 6, 2018 · 5 comments

Comments

@alexeckermann
Copy link
Owner

editor.ui.view is not directly extendable as an editor may not define its template in that view alone. An EditorUIView subclass may be a container which references several distinct child views which may or may not be structurally contained within this view in the DOM, or if the view has a DOM element at all. This was a misunderstanding based upon an incorrect test environment.

The ClassicTestEditor initialises the editor differently to a non-test ClassicEditor, rendering before its supposed to. Moreover, the structure of this test editor lead to a misunderstand of what a typical editor structure is and what view is available to have its template extended. This issue is being resolved in ckeditor5-core#137.

However, the plugin must be more resilient to handle the very rare case where a new or updated editor class does not have a known view to extend.

alexeckermann added a commit that referenced this issue Jul 6, 2018
… raises log messages if it cant support the given editor.
@alexeckermann
Copy link
Owner Author

alexeckermann commented Jul 9, 2018

Pull request #6 failed to rectify the problem. More work will be needed to find an appropriate state method for extending the editable view.

@alexeckermann
Copy link
Owner Author

PR's related to ckeditor/ckeditor5#1150 will resolve this issue.

Some editor's would call methods that render their editable views in their constructors. This prevents any plugin from being able to call extendTemplate on any of those rendered views.

@oleq
Copy link

oleq commented Jul 26, 2018

I merged all PRs related to ckeditor/ckeditor5#1150. Again, huge thanks for your contribution! 👏

I hope you can take your plugin to the next level now! 🚀🚀🚀

@alexeckermann
Copy link
Owner Author

Note: To anyone running CK v11.0 and experiencing issues with variables in editors other than ClassicEditor please use the branch issue-5. Some editors will also require the upstream release of iteration 20 by the CK team before this issue is fully resolved. ETA very soon.

alexeckermann added a commit that referenced this issue Oct 11, 2018
Fixes issue #5 for extending editor.ui.view template
@alexeckermann
Copy link
Owner Author

With the release of CKEditor v11.1 comes the changes needed in the editors to fix this issue.

Please see the updated README for updated information on the implementation of this plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants