Repository navigation
fix(sidebar): show Input for every pending question, including async ones - #57
Merged
Merged
Conversation
alexcstark
added a commit
that referenced
this pull request
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Codex asks a question without stopping (
delivery: "async", stored as a message-mode runtime request), the sidebar, status pill, and mobile thread list kept showing Working for as long as the run continued. The question was only visible inside the thread. In practice this hid real decisions (e.g. a position-sizing question) behind a long "Working 19m" badge, while the agent kept going on a guess.#53 made blocking (
live) questions show Input during a running turn, but deliberately left async ones on Working (upstream pingdotgg#15258).Fix
An unanswered question now always wins over Working:
hasPendingUserInputalone decides Input (approvals still outrank it). That makes the response-capability distinction unnecessary on clients, so this also removes the plumbing #53 added for it:packages/client-runtime: deletethreadHasBlockingPendingUserInputand thependingUserInputResponseCapabilityshell field;isThreadWorkingno longer folds threads with a pending question into the Working section.apps/webSidebar.logic.tsandapps/mobilethreadListV2.ts: checkhasPendingUserInputdirectly.packages/contracts/apps/serverProjectionStore.ts/apps/mobileuse-thread-selection.ts: drop the optionalresponseCapabilityTypefrom the pending-request shell summary (it was fork-only and only fed this rule; it wasoptionalKey, so older peers are unaffected).Net: 20 insertions, 242 deletions. The agent still keeps running on async questions; only the label changes.
Verification
vp test runonentities.test.ts,Sidebar.logic.test.ts,threadListV2.test.ts,ProjectionStore.test.ts: 305 passed. Tests that asserted Working for a pending question during a live run now assert Input / Awaiting Input; they passed with the opposite expectation on main.tsc --noEmitclean for contracts, client-runtime, web, mobile, server. Lint: no new warnings.🤖 Generated with Claude Code (Opus 5.5)