-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: setting permission mask in Entry
and Archive
#330
Conversation
Another solution is that we can have a |
@weihanglo I would suggest splitting the UNC path fix into a separate PR? And I do think mask would be more convenient than mode, since then tar can still handle "executable or not" itself. |
Entry
Entry
and Archive
Thanks @joshtriplett. #331 has been created for UNC path fix. And this PR is also switched to |
Thanks! Right now the mask looks like it's inverted when applying against a mode, so could that be documented? Either that or could the mask not be inverted and the default mask is |
This is convenience when you want to disable some permission bits during unpacking. Currently only support Unix.
Thanks for the review! I went ahead with a logical notation. If you like not inverted one please let me know :) |
Thank you so much Alex! Just a little wish: Could we have a new release for the latest patches? :) |
Sorry for the delay, but sure yeah published now. |
) This is convenience when you want to disable some permission bits during unpacking. Currently only support Unix. (cherry picked from commit 1fd8b4e)
This is convenience when you want to disable some permission bits
during unpacking. Currently only support Unix.