Skip to content

Rewrite test to remove outdated dependencies #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Expyron
Copy link

@Expyron Expyron commented Jul 5, 2025

The goal is mainly to remove the dev-dependency on a very old version of mio.

@alexcrichton
Copy link
Owner

Could you elaborate a bit more on the rationale for this? The purpose of this test is to ensure that using an external event loop is possible, and it looks like your changes effectively make the test busy loop as opposed to use an external event loop?

@Expyron
Copy link
Author

Expyron commented Jul 7, 2025

Maybe I misunderstood the purpose of this test; my understanding was that it was only intended to test the Multi::assign() API which is not tested anywhere else.

My goal was to remove the dependency to a very old version of mio, and mio-extras, which is not supported anymore.

I intially tried to just update mio, but reproducing the functionality of mio-extras would require making the implementation overly complex for just a single test, so I ended up removing mio altogether.

As a clarification: the new version does not busy loop, but does thread::sleep() respecting the timeout provided by libcurl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants