Add secrets #3
Open
Add secrets #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable and implement secrets file, allowing credentials to securely be stored and access preventing plaintext passwords from being present in working script.
Enable index as variable so we only have to change it in one place.
Motivation and Context
Currently credentials, passwords, and endpoints are all plaintext in the script; this is an unnecessary risk and utilizing a secrets file allows one to store credentials separately and more securely.
Also, currently if one wants to change the index they are deduplicating it has to be adjusted in two places. As the script grows in functionality and complexity it is desired to be only need to be changed in one place.
How Has This Been Tested?
Implemented and tested multiple times on local and production environments.