Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump ask-smapi-model to v1.19.7 and update Github Actions #431

Merged
merged 3 commits into from
Apr 20, 2022
Merged

feat: bump ask-smapi-model to v1.19.7 and update Github Actions #431

merged 3 commits into from
Apr 20, 2022

Conversation

Shreyas-vgr
Copy link
Contributor

@Shreyas-vgr Shreyas-vgr commented Apr 18, 2022 •
edited
Loading

Description of changes:

  • feat: bump ask-smapi-model to v1.19.7
  • update Github Actions workflows with node 14, 16 versions
  • Bug fix broken unit tests on node v16 versions by checking for null

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions bot requested a review from doiron April 18, 2022 22:52
@Shreyas-vgr Shreyas-vgr changed the title feat: bump ask-smapi-model to v1.19.6 and update Github Actions feat: bump ask-smapi-model to v1.19.7 and update Github Actions Apr 19, 2022
tkm22
tkm22 approved these changes Apr 19, 2022
View reviewed changes
Copy link

@tkm22 tkm22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be better to explain more details in topic, like fixing xxx tests instead of update github actions.

@Shreyas-vgr
Copy link
Contributor Author

Will be better to explain more details in topic, like fixing xxx tests instead of update github actions.

Apologies will update

@Shreyas-vgr Shreyas-vgr merged commit bd990d7 into develop Apr 20, 2022
@doiron doiron deleted the shreraju/BumpSmapiModelsv1.19.6 branch March 16, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doiron doiron doiron approved these changes

@CamdenFoucht CamdenFoucht CamdenFoucht approved these changes

@tkm22 tkm22 tkm22 approved these changes

Assignees

@Shreyas-vgr Shreyas-vgr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Shreyas-vgr @doiron @CamdenFoucht @tkm22 @shreraju-amzn