Convert obs_space.keys() to list before in check

[alex404]

I was having issues with a statement like this in my own codebase. obs_space.keys() returns a view object apparently, and needs to be converted to a list for this condition to ever be satisfied.

If you check the debug logs when running the battle env, you'll see:

[2023-06-30 12:12:14,201][2413634] Conv encoder output size: 512
[2023-06-30 12:12:14,201][2413634] Policy head output size: 512

After this change you get:

[2023-06-30 12:13:13,133][2415262] Conv encoder output size: 512
[2023-06-30 12:13:13,134][2415262] Policy head output size: 640

[alex-petrenko]

Wow! Great catch!

So does this mean that measurements weren't actually added to the observations?

[alex-petrenko]

I think it got broken somewhere along the way. It might be that after one of the updates of Gym or Gymnasium this regressed. Anyway, thank you for finding this!!

[alex404]

As far as I can tell yah, they weren't being added. ky in obs_space.keys() evaluates to False whatever the value of ky. This seems to be specific to the definition of Dict in gym/nasium. This seems really misleading, tbh. Maybe I'll raise an issue over on the gymnasium repo.

Edit: Yah exactly, it might have been changed in a gym/nasium update.