Add Nodes Contribution workflow summary node #2
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| def _installed_suites(self) -> Dict[str, set[str]]: | ||
| class_map = self._iter_node_class_mappings() | ||
| suites: Dict[str, set[str]] = defaultdict(set) | ||
| for node_id, cls in class_map.items(): | ||
| rel_module = getattr(cls, "RELATIVE_PYTHON_MODULE", None) | ||
| suite = self._suite_from_python_module(rel_module) | ||
| suites[suite].add(node_id) |
There was a problem hiding this comment.
[P1] Fails to identify suites for nodes without RELATIVE_PYTHON_MODULE
Suite detection depends entirely on cls.RELATIVE_PYTHON_MODULE, but most node classes (including those defined in this repository) do not set that attribute. When these nodes are inspected, _suite_from_python_module receives None and all such nodes are collapsed under "Unknown", so the returned breakdown cannot differentiate between custom suites. Consider falling back to cls.__module__ (or other metadata) when RELATIVE_PYTHON_MODULE is missing to produce meaningful counts.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68d6829697088327a68ff0d4a4347b84