Add Docs for Ralph Danube Features #492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polarker
reviewed
Apr 8, 2025
docs/ralph/danube-features.md
Outdated
|
|
||
| There are a few things worth emphasizing here: | ||
|
|
||
| - TxScript can only chain the asset outputs from the contract call, contract output cannot be chained |
There was a problem hiding this comment.
TxScript can only chain the asset outputs of the callers. If the asset outputs are for non-callers, then they can't be chained either.
def chainCallerOutputs(frameBalanceState: MutBalanceState): ExeResult[Unit] = {
EitherF.foreachTry(allInputAddresses.toIterable) { caller =>
docs/ralph/danube-features.md
Outdated
|
|
||
| The Danube upgrade introduces the `@preserveCaller` function annotation. When a function is annotated with `@preserveCaller`, the caller information is preserved for the next function call in the chain. | ||
|
|
||
| More specifically, if a `@preserveCaller` annotated function calls another function, the `callerAddress!()` in the called function will return the caller address of the annotated function rather than the annotated function itself. This feature is particularly valuable for implementing routing patterns in smart contracts, where maintaining the identity of the original caller is essential for proper access control and authorization. |
There was a problem hiding this comment.
Let's note that the same mechanism works for externalCallerAddress!()
docs/ralph/danube-features.md
Outdated
| Here's an example of how `@preserveCaller` works: | ||
|
|
||
| ```rust | ||
| Contract PreserveCaller(internal: PreserveCallerInternal) { |
There was a problem hiding this comment.
How about naming it Rounter since it's the most common use case?
docs/ralph/danube-features.md
Outdated
| pub fn ifStmts(x: U256, y: U256) -> U256 { | ||
| let num1 = if (x > y) 1 else 0 | ||
| let num2 = if x > y 1 else 0 | ||
| let num3 = if x > y { log(x) 1 } else { log(x) 0 } |
There was a problem hiding this comment.
This isn't recommended. Better do this. We will introduce fmt for such cases.
let num3 = if x > y {
log(x)
1
} else {
log(x)
0
}
There was a problem hiding this comment.
Let's also add this change: alephium/alephium#1255 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.