Skip to content
This repository has been archived by the owner on Oct 11, 2022. It is now read-only.

Fix builds and blank app screen #24

Merged
merged 7 commits into from
Jun 30, 2022
Merged

Conversation

tillprochaska
Copy link
Contributor

@tillprochaska tillprochaska commented Jun 24, 2022

This PR includes fixes a numer of small issues. It should build successfully again and display the UI as expected on startup.

To build the app, simply run make build. I’ve manually tested the following features:

  • Export as SVG
  • New file
  • Save
  • Save as
  • Open
  • Add a new entity
  • Create a link between two entities
  • Change entity properties
  • "Unsaved changes" indicator displayed in title bar

Close #16

Otherwise the app will err on startup, as `preload.js` is referenced in when initializing the app window.
electron-builder < 23.0.3 does not work with macOS >= 12.3.

Reference: electron-userland/electron-builder#6732
he Electron documentation recommends restricting access of renderer processes to Electron APIs (such as ipcRenderer.on/send) as much as possible for security reasons.

See: https://www.electronjs.org/docs/latest/tutorial/ipc#2-expose-ipcrendereron-via-preload
@Rosencrantz Rosencrantz merged commit 4374ea2 into master Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't see document edit window
2 participants