Update to React 17 #4057
Merged
Update to React 17 #4057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`componentWillReceiveProps` The latter has been deprecated and will stop working in React 18
…ops` The `EntityViewer` component displays a list of fields for the following entity properties: 1. Feature properties (no matter whether the property has a value or not) 2. Properties with at least one value 3. Properties manually added by the user using the "Add a property" select The previous implementation kept a list of all visible properties (1-3) in the component state. It used the `componentWillReceiveProps` hook to reset this list when a user selected a different entity. The new implementation keeps only the selected properties (3) in the component state. Featured and non-empty properties (1+2) can be derived from the `entity` property at render time. In order to reset the list of selected properties when the user selects a different entity, we use the entity ID as a key. When the entity ID changes, React instantiates a new component (with fresh state) rather than reusing the component rendered for the previous entity.
The previous implementation computed this once when the component is instantiated, this type of state is a common source of bugs. The new implementation computes the list at render time which has a small, but negligible overhead, and is simpler.
… as `react-truncate` hasn’t been updated for a long time and is incompatible with React 17+.
tillprochaska
force-pushed
the
update-react
branch
2 times, most recently
from
e53b773 to
f985274
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates React from version 16 to 17. I had to slightly adjust code in two places due to features that were deprecated and also had to remove the
react-truncatepackage as it hasn’t been updated to support recent React versions (which in that particular case is a good thing anyway as the same effect provided by the package can be achieved with pure cSS). Apart from that, the update is fairly straight-forward.