Bump react-pdf from 5.7.2 to 7.7.3 in /ui #3726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [react-pdf](https://github.com/wojtekmaj/react-pdf/tree/HEAD/packages/react-pdf) from 5.7.2 to 7.7.3. - [Release notes](https://github.com/wojtekmaj/react-pdf/releases) - [Commits](https://github.com/wojtekmaj/react-pdf/commits/v7.7.3/packages/react-pdf) --- updated-dependencies: - dependency-name: react-pdf dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
The text layer is what makes text selectable, but it needs to be aligned in the same way as the underlying canvas that renders the page.
Annotations can be popups, notes, highlights, forms, or clickable links. We currently do not render annotations. While the use of the `renderAnnotations` property suggests that annotations were indeed enabled in an earlier version, the property has been renamed long time ago and annotations have (effectively) not been enabled for multiple years now. While it would have been possible to enable annotations again, I think keeping them disabled is actually sensible as they bear some risk due to their interactive nature.
|
@catileptic @Rosencrantz @stchris I’ve fixed breaking changes for this version upgrade would appreciate a quick review from you. I’ve manually verified the changes using the following PDF files which should cover the main PDF features we care about: rendering of scanned, OCR’ed pages, text rendering and selection, interactive elements such as links. Can you think of any other PDF features we rely on and that we should test explicitly? |
|
@tillprochaska you could try the pdfs from here https://github.com/alephdata/ingest-file/tree/main/tests/fixtures |
stchris
pushed a commit
that referenced
this pull request
May 22, 2024
* Bump react-pdf from 5.7.2 to 7.7.3 in /ui Bumps [react-pdf](https://github.com/wojtekmaj/react-pdf/tree/HEAD/packages/react-pdf) from 5.7.2 to 7.7.3. - [Release notes](https://github.com/wojtekmaj/react-pdf/releases) - [Commits](https://github.com/wojtekmaj/react-pdf/commits/v7.7.3/packages/react-pdf) --- updated-dependencies: - dependency-name: react-pdf dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Fix alignment of invisible text layer The text layer is what makes text selectable, but it needs to be aligned in the same way as the underlying canvas that renders the page. * Do not render annotations Annotations can be popups, notes, highlights, forms, or clickable links. We currently do not render annotations. While the use of the `renderAnnotations` property suggests that annotations were indeed enabled in an earlier version, the property has been renamed long time ago and annotations have (effectively) not been enabled for multiple years now. While it would have been possible to enable annotations again, I think keeping them disabled is actually sensible as they bear some risk due to their interactive nature. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Till Prochaska <1512805+tillprochaska@users.noreply.github.com>
tillprochaska
added a commit
that referenced
this pull request
May 22, 2024
* Bump react-pdf from 5.7.2 to 7.7.3 in /ui Bumps [react-pdf](https://github.com/wojtekmaj/react-pdf/tree/HEAD/packages/react-pdf) from 5.7.2 to 7.7.3. - [Release notes](https://github.com/wojtekmaj/react-pdf/releases) - [Commits](https://github.com/wojtekmaj/react-pdf/commits/v7.7.3/packages/react-pdf) --- updated-dependencies: - dependency-name: react-pdf dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Fix alignment of invisible text layer The text layer is what makes text selectable, but it needs to be aligned in the same way as the underlying canvas that renders the page. * Do not render annotations Annotations can be popups, notes, highlights, forms, or clickable links. We currently do not render annotations. While the use of the `renderAnnotations` property suggests that annotations were indeed enabled in an earlier version, the property has been renamed long time ago and annotations have (effectively) not been enabled for multiple years now. While it would have been possible to enable annotations again, I think keeping them disabled is actually sensible as they bear some risk due to their interactive nature. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Till Prochaska <1512805+tillprochaska@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps react-pdf from 5.7.2 to 7.7.3.
Release notes
Sourced from react-pdf's releases.
... (truncated)
Commits
1a69776v7.7.3208f28dForce isEvalSupported to false8ca4d07v7.7.2260295bForce isEvalSupported to true93b09c3v7.7.1f01d41eBump eslint-config-wojtekmaj from 0.9.0 to 0.11.0a9d0b52Bump eslint from 8.37.0 to 8.56.057eaaf7Bump jsdom from 21.1.1 to 24.0.0e339525Fix Outline, Page and Thumbnail components crashing when placed outside Documentcf5327bAdd missing linkService in DocumentContext in unit testsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.