-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to convert-document #3681
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few remarks, thanks for cleaning this up!
Thanks so much for reviewing. I believe I made all the changes requested. A couple of unrelated things I noticed:
|
Thanks for your changes, I will review them shortly!
Ah yes, good observation. I believe for consistency we should do this in a separate PR across all of our documentation.
Another good observation. So if one uses our Helm chart everything would be prefixed with |
Thanks for your contribution, @friendly-wolfbat |
@stchris Hey, I'm sorry, it looks like the hyperlink I had to the installation page is wrong, when looking at the "Checks" tab. Should I have put a slash before the hashtag? |
Don't worry about it, @friendly-wolfbat ! It is our fault because there need to be some CI checks on PRs which are currently not in place. I will take care of fixing it. |
Per #3680 (comment), I am attempting a pull request to remove references to the old
convert-document
container, which has since been consolidated intoingest-file
(see #2755).This is my first pull request and I am open to learning! Please let me know if anything is wrong or if I need to make any adjustments.