-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumps version of FTM libs, SQLAlchemy, Flask and related to latest #3160
Conversation
In order for the tests to pass, this PR in FTM needs to be merged and a new version of FTM needs to be released. Then, the FTM version in Aleph needs to be changed as well. |
The versions of the following packages were increased to the latest versions: `followthemoney`, `followthemoney-store`, `servicelayer`. Due to the fact that all 3 libraries use a newer version of `SQLAlchemy`, the versions of the following packages were also bumped to latest: `Flask`, `Flask-SQLAlchemy`, `SQLAlchemy`, `Flask-Babel`. The commit also includes minor refactorings necessary as a result of these version bumps. * `core.py` was refactored due to the `Flask-Babel` version bump [as per the docs](https://python-babel.github.io/flask-babel/#configuration) * `migration.py`, `util.py` and `archive_api.py` were refactored due to the `SQLAlchemy` version bump
3fdf988
to
b133daa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, looks good to me! 👏 Left some comments about some minor version bumps we might want to do at this time as well.
The versions of the following packages were increased to the latest versions:
followthemoney
,followthemoney-store
,servicelayer
. Due to the fact that all 3 libraries use a newer version ofSQLAlchemy
, the versions of the following packages were also bumped to latest:Flask
,Flask-SQLAlchemy
,SQLAlchemy
,Flask-Babel
.The commit also includes minor refactorings necessary as a result of these version bumps.
core.py
was refactored due to theFlask-Babel
version bump as per the docsmigration.py
,util.py
andarchive_api.py
were refactored due to theSQLAlchemy
version bumparchive.apy
was refactored as per this interface change