Switch to rabbitmq based task queue #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move worker to servicelayer - Use pytest to run tests
pudo
reviewed
Apr 5, 2022
aleph/worker.py
Outdated
Comment on lines
43
to
44
| def op_index(collection_id, batch, worker=None): | ||
| collection = Collection.by_id(collection_id) |
There was a problem hiding this comment.
Are you still ensuring that all the documents in the whole batch are from the same collection? I would consider sending the collection as a dict as part of the indexing requests pretty soon after making this change, I think it'll be a perf game changer...
There was a problem hiding this comment.
@pudo So we want to batch indexing tasks irrespective of collection?
This was referenced May 17, 2022
sunu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.