fix: timeout error caused by long IPFS file stat operation #885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ipfs/add_file` endpoint fails randomly because of a 5 second timeout when stat-ing the file to retrieve its size. Increased the timeout to 30 seconds, made it configurable through the `ipfs.stat_timeout` config value and return a 404 from the endpoint if the stat op times out nonetheless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ipfs/add_fileendpoint fails randomly because of a 5 second timeout when stat-ing the file to retrieve its size.Increased the timeout to 30 seconds, made it configurable through the
ipfs.stat_timeoutconfig value and return a 404 from the endpoint if the stat op times out nonetheless.