fix: avoid subqueries when calling /messages without parameters #877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `/messages` endpoint returns the number of matching messages. As an optimization for the default case with no filters, we return an approximate (fast) count of the total number of messages, and accept the performance penalty when specifying filters. The condition to determine whether we go through the fast path was weirdly designed (it depends on an empty `kwargs`) and new features introduced a bug where the fast path is never used anymore. This currently happens because of `start_block` and `end_block`, but also `message_statuses`. This PR fixes the issue for start/end blocks, the issue with message statuses requires more investigation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
/messagesendpoint returns the number of matching messages. As an optimization for the default case with no filters, we return an approximate (fast) count of the total number of messages, and accept the performance penalty when specifying filters.The condition to determine whether we go through the fast path was weirdly designed (it depends on an empty
kwargs) and new features introduced a bug where the fast path is never used anymore.This currently happens because of
start_blockandend_block, but alsomessage_statuses.This PR fixes the issue for start/end blocks, the issue with message statuses requires more investigation.