Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Wallet Connect #1

Merged
merged 22 commits into from
May 17, 2024
Merged

feat: Wallet Connect #1

merged 22 commits into from
May 17, 2024

Conversation

ricardocr987
Copy link
Contributor

@ricardocr987 ricardocr987 commented Mar 6, 2024

Changes:

  • AppStateContext now exposes the functions of useConnection, also the state about the connection.
  • useConnection implements auto-login and is ready to handle multiple connection implementations, such as MetaMask and WalletConnect
  • useMetamask sets up the listeners and callbacks
  • useWalletConnect initializes the client only when required and manages its own listeners.

There is one problem with this implementation yet: In wallet connect, you need to connect to all required chains at the same time on the first connection, then the wallet does not need to switch chains because it is already connected, ideally I would allow in applications to connect several networks, wallet picker should accept multiple connected network.

@ricardocr987 ricardocr987 marked this pull request as ready for review April 15, 2024 09:29
@MHHukiewitz MHHukiewitz self-requested a review April 15, 2024 18:13
@amalcaraz amalcaraz merged commit 583ded8 into main May 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants