Fix issue with HaProxy domain mapping #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olethanh
force-pushed
the
ol-ALEPH-haproxy-mapping
branch
from
42a7c15 to
24d515f
Compare
nesitor
reviewed
Jul 29, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #826 +/- ##
==========================================
- Coverage 64.80% 64.57% -0.23%
==========================================
Files 87 87
Lines 8021 8048 +27
Branches 716 722 +6
==========================================
- Hits 5198 5197 -1
- Misses 2590 2624 +34
+ Partials 233 227 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Problem: Haproxy was not properly configured. And request could go to any server Analysis: Previously we added backend server via but not the mapping. And the map file was not correctly configured Solution: Update HaProxy mapping as well as backend server via the control socket Fix the way mapping is done: Target should be server name not addr:port Update the haproxy config to only use the fallback server if no mapping if found, otherwise it could be randomly used. Update tests
olethanh
force-pushed
the
ol-ALEPH-haproxy-mapping
branch
from
24d515f to
e5dd88a
Compare
nesitor
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA ticket ALEPH-636
Problem:
Haproxy was not properly configured. And request could go to any server
Analysis:
Previously we added backend server via but not the mapping.
And the map file was not correctly configured
Solution:
Update HaProxy mapping as well as backend server via the control socket
Fix the way mapping is done: Target should be server name not addr:port
Update the haproxy config to only use the fallback server if no mapping if found, otherwise it could be randomly us
Update tests