Skip to content

Solve firewall redirect issues #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 11, 2025
Merged

Solve firewall redirect issues #813

merged 6 commits into from
Jun 11, 2025

Conversation

olethanh
Copy link
Collaborator

@olethanh olethanh commented Jun 6, 2025

Fixed issues related with Firewall redirection rules on ports.

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.27%. Comparing base (35ce27f) to head (9640a4c).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/aleph/vm/pool.py 16.66% 5 Missing ⚠️
src/aleph/vm/orchestrator/metrics.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #813      +/-   ##
==========================================
- Coverage   65.27%   65.27%   -0.01%     
==========================================
  Files          85       85              
  Lines        7681     7685       +4     
  Branches      664      664              
==========================================
+ Hits         5014     5016       +2     
- Misses       2457     2460       +3     
+ Partials      210      209       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

olethanh added 3 commits June 6, 2025 18:46
this is not an issue to call it twice anymore since we
now check for double creation
if multiple instance execution were present in the DB
when loading_persistant_execution
we could take a recent one and not the latest
Caused by a comparisonfail due to a type change
@nesitor nesitor changed the title Ol firewall again Solve firewall redirect issues Jun 11, 2025
@nesitor nesitor merged commit 12496c1 into main Jun 11, 2025
20 of 22 checks passed
@nesitor nesitor deleted the ol-firewall-again branch June 11, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants