Skip to content

Fix issue on port directions #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 5, 2025
Merged

Conversation

olethanh
Copy link
Collaborator

@olethanh olethanh commented Jun 5, 2025

  • Port redirect: Only redirect for instance
  • Port redirect: Avoid redirecting the same port

Root cause:
The list of rule fetched from ntfable was filtered on the nat table
that didn't contain the redirection so we missed existing redirect

Related ClickUp, GitHub or Jira tickets : ALEPH-551

olethanh added 2 commits June 5, 2025 10:58
Root cause:
The list of rule fetched from ntfable was filtered on the nat table
that didn't contain the redirection so we missed existing redirect
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 64.65%. Comparing base (28a4d09) to head (507dd98).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/aleph/vm/models.py 50.00% 2 Missing and 1 partial ⚠️
src/aleph/vm/network/firewall.py 66.66% 3 Missing ⚠️
src/aleph/vm/pool.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #810      +/-   ##
==========================================
+ Coverage   64.63%   64.65%   +0.01%     
==========================================
  Files          84       84              
  Lines        7576     7577       +1     
  Branches      651      651              
==========================================
+ Hits         4897     4899       +2     
+ Misses       2471     2470       -1     
  Partials      208      208              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nesitor nesitor merged commit a787875 into main Jun 5, 2025
20 of 22 checks passed
@nesitor nesitor deleted the ol-ALEPH-551-ipv4_port_forwarding_fix branch June 5, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants