Skip to content

Solve message requirements casting issue #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

nesitor
Copy link
Member

@nesitor nesitor commented Apr 16, 2025

Fix: Solve message class casting issue with requirements field.

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.
  • Dependencies update in the project.toml have been mirrored in the Debian package build script packaging/Makefile

Changes

Removed InstanceContent casting and put it as ExecutableContent.

How to test

Create a VM with GPU and check that the VM is running.

@nesitor nesitor requested a review from olethanh April 16, 2025 12:07
@nesitor nesitor self-assigned this Apr 16, 2025
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.56%. Comparing base (28582cf) to head (e7570cd).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/aleph/vm/pool.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #800      +/-   ##
==========================================
+ Coverage   64.53%   64.56%   +0.02%     
==========================================
  Files          78       78              
  Lines        7092     7092              
  Branches      598      598              
==========================================
+ Hits         4577     4579       +2     
+ Misses       2315     2313       -2     
  Partials      200      200              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@olethanh olethanh merged commit 7bf21b0 into main Apr 16, 2025
35 of 37 checks passed
@nesitor nesitor deleted the andres-fix-solve_message_casting_issue branch April 16, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants