Skip to content

Fix VM lifecycle and blocking resource. #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 7, 2025
Merged

Fix VM lifecycle and blocking resource. #789

merged 5 commits into from
Apr 7, 2025

Conversation

olethanh
Copy link
Collaborator

@olethanh olethanh commented Mar 28, 2025 •
edited
Loading

Fix the issue with VM starting and not freeing resource properly

Related ClickUp, GitHub or Jira tickets : ALEPH-287 ALEPH-471

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.
  • Dependencies update in the project.toml have been mirrored in the Debian package build script packaging/Makefile

@olethanh olethanh force-pushed the ol-fix-vm-lifecycle branch from 5c93a82 to 92526af Compare March 31, 2025 07:12
@olethanh olethanh changed the title Ol fix vm lifecycle Fix VM lifecycle and blocking resource. Apr 1, 2025
@olethanh olethanh marked this pull request as ready for review April 1, 2025 13:29
@olethanh olethanh force-pushed the ol-fix-vm-lifecycle branch from 92526af to 04c4b8e Compare April 1, 2025 13:45
olethanh added 4 commits April 1, 2025 15:46
@olethanh
Fix leftover network when VM fail to start
63c24b9 
Fix Network interface being left over when VM fail to start

Change:
Move the code startup persistant instance inside VmExecution.start
so it is properly catched by the clean up code
@olethanh
Stop the guest api if a VM fail to start
e7129fd
@olethanh
Clean up: Remove unused MicroVm.stdoud_task and stderr_task
8e590d1
@olethanh
Add lock arround the update_allocation commands
eed2378 
This prevent two allocation from running in parallel and causing racing error
@olethanh olethanh force-pushed the ol-fix-vm-lifecycle branch from 04c4b8e to eed2378 Compare April 1, 2025 13:46
@codecov Codecov
Copy link

codecov bot commented Apr 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 21.42857% with 44 lines in your changes missing coverage. Please review.

Project coverage is 64.54%. Comparing base (2221cd4) to head (3545506).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/aleph/vm/orchestrator/views/__init__.py 25.00% 30 Missing and 6 partials ⚠️
src/aleph/vm/models.py 0.00% 7 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #789      +/-   ##
==========================================
+ Coverage   64.50%   64.54%   +0.03%     
==========================================
  Files          78       78              
  Lines        7088     7087       -1     
  Branches      598      597       -1     
==========================================
+ Hits         4572     4574       +2     
+ Misses       2314     2312       -2     
+ Partials      202      201       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@olethanh
CI: Raise dpkg lock limit that was causing crash
3545506 
set it as ilimited there is a global limit for the CI so rely on this instead.
@olethanh olethanh requested a review from nesitor April 7, 2025 10:45
nesitor
nesitor approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@nesitor nesitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@olethanh olethanh merged commit ba72293 into main Apr 7, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nesitor nesitor nesitor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olethanh @nesitor