Skip to content

Check community payment flow #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

olethanh
Copy link
Collaborator

WIP

Related ClickUp, GitHub or Jira tickets : ALEPH-401

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.
  • Dependencies update in the project.toml have been mirrored in the Debian package build script packaging/Makefile

Changes

Explain the changes that were made. The idea is not to list exhaustively all the changes made (GitHub already provides a full diff), but to help the reviewers better understand:

  • which specific file changes go together, e.g: when creating a table in the front-end, there usually is a config file that goes with it
  • the reasoning behind some changes, e.g: deleted files because they are now redundant
  • the behaviour to expect, e.g: tooltip has purple background color because the client likes it so, changed a key in the API response to be consistent with other endpoints

How to test

Explain how to test your PR.
If a specific config is required explain it here (account, data entry, ...)

Print screen / video

Upload here screenshots or videos showing the changes if relevant.

Notes

Things that the reviewers should know: known bugs that are out of the scope of the PR, other trade-offs that were made.
If the PR depends on a PR in another repo, or merges into another PR (i.o. main), it should also be mentioned here

@nesitor nesitor changed the base branch from main to andres-feature-implement_gpu_compatibility February 13, 2025 20:35
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 81.55340% with 38 lines in your changes missing coverage. Please review.

Project coverage is 64.08%. Comparing base (891a437) to head (c82fd90).
Report is 1 commits behind head on andres-feature-implement_gpu_compatibility.

Files with missing lines Patch % Lines
src/aleph/vm/orchestrator/utils.py 63.63% 11 Missing and 5 partials ⚠️
src/aleph/vm/orchestrator/views/__init__.py 16.66% 15 Missing ⚠️
src/aleph/vm/orchestrator/tasks.py 76.92% 5 Missing and 1 partial ⚠️
tests/supervisor/test_checkpayment.py 99.13% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                              Coverage Diff                               @@
##           andres-feature-implement_gpu_compatibility     #751      +/-   ##
==============================================================================
+ Coverage                                       62.95%   64.08%   +1.13%     
==============================================================================
  Files                                              75       76       +1     
  Lines                                            6579     6761     +182     
  Branches                                          542      553      +11     
==============================================================================
+ Hits                                             4142     4333     +191     
+ Misses                                           2273     2249      -24     
- Partials                                          164      179      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nesitor nesitor marked this pull request as ready for review February 17, 2025 13:44
@nesitor nesitor merged commit 10ce55f into andres-feature-implement_gpu_compatibility Feb 17, 2025
29 checks passed
@nesitor nesitor deleted the ol-401-community-payment branch February 17, 2025 13:47
nesitor pushed a commit that referenced this pull request Feb 17, 2025
* Implement community payment check WIP

* isort

* Check community flow at allocation

* Community flow  : fix after testing

* mod Use singleton for the Setting Aggregate

* fix test

* Implement community wallet start time
nesitor added a commit that referenced this pull request Feb 17, 2025
* Feature: Added options to get GPU compatibilities from a settings aggregate.

* Fix: Refactored to also return the model name from the aggregate and use the same device_id format.

* Fix: Include GPU list and move the VM egress IPv6 check on the connectivity check to start notifying the users about the next requirement.

* Fix: Solved code quality issues.

* Fix: Put definitive settings aggregate address

* Fix: Solved issue with type casting and moved the aggregate check.

* Check community payment flow (#751)

* Implement community payment check WIP

* isort

* Check community flow at allocation

* Community flow  : fix after testing

* mod Use singleton for the Setting Aggregate

* fix test

* Implement community wallet start time

---------

Co-authored-by: Olivier Le Thanh Duong <olivier@lethanh.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants