-
Notifications
You must be signed in to change notification settings - Fork 18
Check community payment flow #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nesitor
merged 7 commits into
andres-feature-implement_gpu_compatibility
from
ol-401-community-payment
Feb 17, 2025
Merged
Check community payment flow #751
nesitor
merged 7 commits into
andres-feature-implement_gpu_compatibility
from
ol-401-community-payment
Feb 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## andres-feature-implement_gpu_compatibility #751 +/- ##
==============================================================================
+ Coverage 62.95% 64.08% +1.13%
==============================================================================
Files 75 76 +1
Lines 6579 6761 +182
Branches 542 553 +11
==============================================================================
+ Hits 4142 4333 +191
+ Misses 2273 2249 -24
- Partials 164 179 +15 ☔ View full report in Codecov by Sentry. |
nesitor
approved these changes
Feb 17, 2025
10ce55f
into
andres-feature-implement_gpu_compatibility
29 checks passed
nesitor
pushed a commit
that referenced
this pull request
Feb 17, 2025
* Implement community payment check WIP * isort * Check community flow at allocation * Community flow : fix after testing * mod Use singleton for the Setting Aggregate * fix test * Implement community wallet start time
nesitor
added a commit
that referenced
this pull request
Feb 17, 2025
* Feature: Added options to get GPU compatibilities from a settings aggregate. * Fix: Refactored to also return the model name from the aggregate and use the same device_id format. * Fix: Include GPU list and move the VM egress IPv6 check on the connectivity check to start notifying the users about the next requirement. * Fix: Solved code quality issues. * Fix: Put definitive settings aggregate address * Fix: Solved issue with type casting and moved the aggregate check. * Check community payment flow (#751) * Implement community payment check WIP * isort * Check community flow at allocation * Community flow : fix after testing * mod Use singleton for the Setting Aggregate * fix test * Implement community wallet start time --------- Co-authored-by: Olivier Le Thanh Duong <olivier@lethanh.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Related ClickUp, GitHub or Jira tickets : ALEPH-401
Self proofreading checklist
packaging/Makefile
Changes
Explain the changes that were made. The idea is not to list exhaustively all the changes made (GitHub already provides a full diff), but to help the reviewers better understand:
How to test
Explain how to test your PR.
If a specific config is required explain it here (account, data entry, ...)
Print screen / video
Upload here screenshots or videos showing the changes if relevant.
Notes
Things that the reviewers should know: known bugs that are out of the scope of the PR, other trade-offs that were made.
If the PR depends on a PR in another repo, or merges into another PR (i.o. main), it should also be mentioned here