Skip to content

Ol aleph 166 misc stability #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025
Merged

Ol aleph 166 misc stability #719

merged 2 commits into from
Apr 1, 2025

Conversation

olethanh
Copy link
Collaborator

@olethanh olethanh commented Nov 5, 2024

This is a lot of small improvement to make aleph-vm more usable. I'm putting them all under the banner of the Jira tickets : ALEPH-166

  • Better logging
  • Include the VM hash in logs were relevant (might have missed some place yet) to help debug endpoint
  • Remove the duplicate output of the db logs (sqlalchemy)
  • Ensure logs for http request are printed
  • Set default level for logging to INFO (so node owner have useful info by default for debugging problem)
  • Improve the developer documentation
  • Fix some tests precondition
  • Fix docstirngs
  • Fix hatch fmt command (and ruff fmt )
  • Less crap in the program output in general
  • Don't check payment for fake debug instances.
  • Ability to set the LOG level via an environment variable (replace Fix: Log level could not be configured from settings #581 )

@olethanh olethanh force-pushed the ol-ALEPH-166-misc-stability branch from 366dde2 to 2a03112 Compare November 5, 2024 14:28
@olethanh olethanh force-pushed the ol-ALEPH-166-misc-stability branch from 2a03112 to 2451a0c Compare November 13, 2024 10:49
@olethanh olethanh marked this pull request as ready for review November 13, 2024 10:51
@olethanh olethanh force-pushed the ol-ALEPH-166-misc-stability branch from 2451a0c to 31c41ed Compare November 13, 2024 10:53
@olethanh olethanh requested review from nesitor and hoh and removed request for nesitor November 14, 2024 15:45
@olethanh olethanh force-pushed the ol-ALEPH-166-misc-stability branch from 0a4b2d6 to 3f88fe4 Compare December 10, 2024 11:26
@olethanh olethanh force-pushed the ol-ALEPH-166-misc-stability branch from 3f88fe4 to 0dfdcc0 Compare March 31, 2025 14:26
Don't call pyaleph if there is no execution for user
Remove debug executions
@olethanh olethanh force-pushed the ol-ALEPH-166-misc-stability branch from 0dfdcc0 to 62a0fed Compare March 31, 2025 15:47
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 64.50%. Comparing base (c45346c) to head (62a0fed).

Files with missing lines Patch % Lines
src/aleph/vm/orchestrator/cli.py 0.00% 6 Missing ⚠️
src/aleph/vm/orchestrator/tasks.py 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #719      +/-   ##
==========================================
- Coverage   64.54%   64.50%   -0.05%     
==========================================
  Files          78       78              
  Lines        7083     7088       +5     
  Branches      595      598       +3     
==========================================
  Hits         4572     4572              
- Misses       2309     2314       +5     
  Partials      202      202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@olethanh olethanh merged commit eff82dc into main Apr 1, 2025
51 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants