Skip to content

Problem : Log was not working on system. Unify logging method #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 25, 2024

Conversation

olethanh
Copy link
Collaborator

Restore the logging method using systemd and use it on all execution types. This method use the systemd journal library to open a file descriptor, which we pass to the subprocess. This should provide a performance boost since there is no python handling of the process output.

  • Restored the method of logging in journald in Qemu
  • Ported it to Firecracker hypervisor
  • Now all Execution (program / instance qemu / firecracker) use the same unified logging method.
  • Streaming Logging endpoint now works properly and return all logs.
  • As per discussion: PRINT_SYSTEM_LOGS only affect Program execution, since we decided it made no sense or performance impact on Instances.
  • When logs are disabled connect the Firecracker VM to /dev/null which should further improve performances.

@olethanh olethanh requested review from hoh and nesitor June 21, 2024 12:43
@olethanh olethanh force-pushed the ol-fix-systemd-logs branch from 61cf8c8 to 7a4ed4f Compare June 21, 2024 12:48
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 55.91398% with 41 lines in your changes missing coverage. Please review.

Project coverage is 59.27%. Comparing base (4060e00) to head (7a4ed4f).
Report is 2 commits behind head on main.

Files Patch % Lines
src/aleph/vm/utils/logs.py 30.00% 21 Missing ⚠️
src/aleph/vm/controllers/interface.py 41.66% 14 Missing ⚠️
src/aleph/vm/hypervisors/firecracker/microvm.py 72.72% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #644      +/-   ##
==========================================
+ Coverage   58.73%   59.27%   +0.53%     
==========================================
  Files          62       63       +1     
  Lines        5482     5419      -63     
  Branches      608      591      -17     
==========================================
- Hits         3220     3212       -8     
+ Misses       2122     2069      -53     
+ Partials      140      138       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nesitor nesitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@olethanh olethanh merged commit ed28be7 into main Jun 25, 2024
23 of 24 checks passed
@Psycojoker Psycojoker deleted the ol-fix-systemd-logs branch July 24, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants