Problem: dbus call were not async #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbus call to systemd were not called asyncronously. Modify all call to asynchronous, this required switching from python-dbus to dbus-fast which offer an asyncio backend.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #595 +/- ##
==========================================
+ Coverage 43.83% 44.04% +0.21%
==========================================
Files 55 55
Lines 4944 5018 +74
Branches 585 594 +9
==========================================
+ Hits 2167 2210 +43
- Misses 2658 2683 +25
- Partials 119 125 +6 ☔ View full report in Codecov by Sentry. |
|
Failed to retrieve llama text: POST 504: 504 Gateway Time-outThe server didn't respond in time. |
hoh
reviewed
Apr 15, 2024
hoh
reviewed
Apr 15, 2024
Upstream is a generic lib for dbus and not fixated on any particular interface. I could split this in another python file if you prefer |
hoh
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbus call to systemd were not called asyncronously and thus were hanging the whole thing
Modify all call to asynchronous, this required switching from
python-dbus to dbus-fast which offer an asyncio backend.
Another adventage of dbus-fast is that is in pure python so won't require libdbus or compilation (also it is packaged in ubuntu & debian )