-
Notifications
You must be signed in to change notification settings - Fork 5
[Fix] Loosen aleph-message dependency #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The PR includes extensive changes, including modifications of dependencies and a new library (aleph-message). This could be risky because it involves potentially breaking changes and requires deep understanding of both the project architecture and Python dependency management. Only experienced developers should review this PR as it may have high potential for introducing bugs or unexpected behavior. The response is designed to be parsed by machines for integration into other systems, therefore its response starts with the exact category ('BLACK') followed by the explaining rationale in subsequent lines using markdown format and bullet points. |
5d0a393
to
fdb53e6
Compare
Rebased on #93 |
Commits mix different topics, can you ensure only the right commits are in this branch ? |
LGTM, but there are some tests that are failing on some distributions. |
Solution: loosen it to accept compatible versions to 0.4.2
Co-authored-by: nesitor <amolinsdiaz@yahoo.es>
Co-authored-by: Hugo Herter <git@hugoherter.com>
Test is failing as aleph-message=0.4.2 has syntax that is not supported anymore in Python 3.8. Should we drop support for that version? |
Yes, we can drop support for Python < 3.9 |
b3292b6
to
2b540ca
Compare
2b540ca
to
a1a809b
Compare
I don't know why the new check for ubuntu 24.04 isn't being picked up on... @hoh |
Failed to retrieve llama text: POST 504: 504 Gateway Time-outThe server didn't respond in time. |
Problem: too strict aleph-message dependency Solution: loosen it to accept compatible versions to 0.4.2 Co-authored-by: mhh <mike.hukiewitz@robotter.ai>
Problem: Too strict aleph-message dependency
Solution: loosen it to accept compatible versions to 0.4.2
EDIT:
aleph-im/aleph-message#91 fixed the backwards compatibility issue.
aleph-message
has been upgraded to 0.4.3 so these workflows pass again