Skip to content

[Fix] Loosen aleph-message dependency #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 12, 2024
Merged

[Fix] Loosen aleph-message dependency #92

merged 12 commits into from
Feb 12, 2024

Conversation

MHHukiewitz
Copy link
Member

@MHHukiewitz MHHukiewitz commented Jan 30, 2024

Problem: Too strict aleph-message dependency

Solution: loosen it to accept compatible versions to 0.4.2

EDIT:
aleph-im/aleph-message#91 fixed the backwards compatibility issue. aleph-message has been upgraded to 0.4.3 so these workflows pass again

Another problem: Further problems arose from importing aleph-message~=0.4.2 due to some newer syntax that was not supported in Python 3.9 yet.

Another solution: EOL for Python 3.9 & out-of-the-box Ubuntu-20.04.

Also fixed deprecation warning for deprecated GH workflows that utilized EOL node.js v16 by using newer versions of those workflows.

@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Jan 30, 2024
Copy link

The PR includes extensive changes, including modifications of dependencies and a new library (aleph-message). This could be risky because it involves potentially breaking changes and requires deep understanding of both the project architecture and Python dependency management. Only experienced developers should review this PR as it may have high potential for introducing bugs or unexpected behavior.

The response is designed to be parsed by machines for integration into other systems, therefore its response starts with the exact category ('BLACK') followed by the explaining rationale in subsequent lines using markdown format and bullet points.

@MHHukiewitz
Copy link
Member Author

Rebased on #93

@hoh
Copy link
Member

hoh commented Feb 1, 2024

Commits mix different topics, can you ensure only the right commits are in this branch ?

@MHHukiewitz
Copy link
Member Author

@hoh First merge #93, then this branch only has one change, which is the setup.cfg file

@nesitor nesitor self-requested a review February 1, 2024 12:08
nesitor
nesitor previously approved these changes Feb 1, 2024
@nesitor
Copy link
Member

nesitor commented Feb 1, 2024

LGTM, but there are some tests that are failing on some distributions.

MHHukiewitz and others added 2 commits February 1, 2024 13:25
Solution: loosen it to accept compatible versions to 0.4.2
Co-authored-by: nesitor <amolinsdiaz@yahoo.es>
@hoh hoh force-pushed the mhh-loosen-deps branch from fdb53e6 to 5c01b92 Compare February 1, 2024 12:25
Co-authored-by: Hugo Herter <git@hugoherter.com>
@MHHukiewitz
Copy link
Member Author

Test is failing as aleph-message=0.4.2 has syntax that is not supported anymore in Python 3.8. Should we drop support for that version?

@hoh
Copy link
Member

hoh commented Feb 2, 2024

Test is failing as aleph-message=0.4.2 has syntax that is not supported anymore in Python 3.8. Should we drop support for that version?

Yes, we can drop support for Python < 3.9

@MHHukiewitz
Copy link
Member Author

I don't know why the new check for ubuntu 24.04 isn't being picked up on... @hoh

Copy link

github-actions bot commented Feb 2, 2024

Failed to retrieve llama text: POST 504:

504 Gateway Time-out


The server didn't respond in time.

@MHHukiewitz MHHukiewitz requested review from nesitor and hoh February 8, 2024 10:15
@MHHukiewitz MHHukiewitz changed the title [Fix] Loosen aleph-message dependency [Fix] Loosen aleph-message dependency & deprecate unsupported Python/Ubuntu distros Feb 8, 2024
@MHHukiewitz MHHukiewitz changed the title [Fix] Loosen aleph-message dependency & deprecate unsupported Python/Ubuntu distros [Fix] Loosen aleph-message dependency Feb 9, 2024
@MHHukiewitz MHHukiewitz requested a review from hoh February 9, 2024 16:52
@hoh hoh merged commit a3e120a into main Feb 12, 2024
@hoh hoh deleted the mhh-loosen-deps branch February 12, 2024 15:34
hoh pushed a commit that referenced this pull request Feb 22, 2024
Problem: too strict aleph-message dependency

Solution: loosen it to accept compatible versions to 0.4.2

Co-authored-by: mhh <mike.hukiewitz@robotter.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLACK This PR has critical implications and must be reviewed by a senior engineer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants