-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Add InsufficientFundsError
in create_instance
#86
Conversation
…rror if error_code is 5 This allows better exception handling when creating instances
d3c0b04
to
3668450
Compare
3668450
to
a033bfe
Compare
The changes in this PR include:
These changes introduce complexity at multiple levels of the codebase, including modifications to core functionality, introduction of a new error type, and updates to testing. As such, this PR requires careful review to ensure that these changes do not introduce bugs or unintended side effects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
submit()
andbroadcast()
methods to addraise_on_rejected
parameter. This allows client methods to implement their own exception handling on broadcast.InsufficientFundsError
if creating an instance failed due to low funds.