Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Add InsufficientFundsError in create_instance #86

Merged
merged 7 commits into from
Dec 4, 2023

Conversation

MHHukiewitz
Copy link
Member

  • Refactor submit() and broadcast() methods to add raise_on_rejected parameter. This allows client methods to implement their own exception handling on broadcast.
  • Implement InsufficientFundsError if creating an instance failed due to low funds.

@MHHukiewitz MHHukiewitz force-pushed the mhh-raise-on-insufficient-funds branch from d3c0b04 to 3668450 Compare December 4, 2023 08:39
@MHHukiewitz MHHukiewitz force-pushed the mhh-raise-on-insufficient-funds branch from 3668450 to a033bfe Compare December 4, 2023 08:44
@MHHukiewitz MHHukiewitz closed this Dec 4, 2023
@MHHukiewitz MHHukiewitz reopened this Dec 4, 2023
@MHHukiewitz MHHukiewitz closed this Dec 4, 2023
@MHHukiewitz MHHukiewitz reopened this Dec 4, 2023
@github-actions github-actions bot added the RED This PR is complex and may require more time to review. label Dec 4, 2023
Copy link

github-actions bot commented Dec 4, 2023

The changes in this PR include:

  1. Adding a new parameter raise_on_rejected to several methods in aleph-sdk-python. This involves modifying function signatures and updating calls to these functions throughout the codebase.
  2. Introducing a new exception InsufficientFundsError in exceptions.py.
  3. Adding a new fixture rejected_message in conftest.py for use in testing.
  4. Updating several test functions to handle the new raise_on_rejected parameter and the new InsufficientFundsError exception.

These changes introduce complexity at multiple levels of the codebase, including modifications to core functionality, introduction of a new error type, and updates to testing. As such, this PR requires careful review to ensure that these changes do not introduce bugs or unintended side effects.

@aleph-im aleph-im deleted a comment from github-actions bot Dec 4, 2023
Copy link
Collaborator

@1yam 1yam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MHHukiewitz MHHukiewitz merged commit ef520a0 into main Dec 4, 2023
11 checks passed
@MHHukiewitz MHHukiewitz deleted the mhh-raise-on-insufficient-funds branch December 4, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RED This PR is complex and may require more time to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants