Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create_instance method #78

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Add create_instance method #78

merged 4 commits into from
Nov 17, 2023

Conversation

MHHukiewitz
Copy link
Member

Introduce create_instance() with slight modifications from aleph-im/aleph-client#156

hoh
hoh previously approved these changes Nov 14, 2023
Copy link

Failed to retrieve llama text: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))

@MHHukiewitz MHHukiewitz reopened this Nov 14, 2023
@github-actions github-actions bot added the RED This PR is complex and may require more time to review. label Nov 14, 2023
Copy link

  • The create_instance method has many parameters with default values, which can make it more challenging to understand its behavior without careful reading.
  • It also utilizes multiple models from the aleph_message.models module and directly interacts with the session object's attributes, increasing the cognitive complexity of understanding its role in the system.
  • The method is asynchronous, which adds another layer of complexity as it requires understanding of Python's asyncio framework.

These factors suggest that this PR should be reviewed by a developer with deep knowledge of the project and familiarity with the libraries used. It would be prudent to assign this PR to an experienced reviewer to minimize the risk of introducing bugs due to misunderstanding the complexity of these changes.

Copy link
Collaborator

@1yam 1yam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MHHukiewitz MHHukiewitz merged commit 773addb into main Nov 17, 2023
22 checks passed
@MHHukiewitz MHHukiewitz deleted the mhh-add-instances branch November 17, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RED This PR is complex and may require more time to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants