Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: macos 11 & 12 build #74

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Fix: macos 11 & 12 build #74

merged 5 commits into from
Nov 8, 2023

Conversation

1yam
Copy link
Collaborator

@1yam 1yam commented Nov 7, 2023

No description provided.

@MHHukiewitz
Copy link
Member

@hoh It seems that only with Python 3.11 the macOS wheel is able to successfully build. Is that fine?

@1yam 1yam changed the title Fix: macos 12 build Fix: macos 11 & 12 build Nov 7, 2023
@MHHukiewitz MHHukiewitz marked this pull request as ready for review November 7, 2023 19:15
MHHukiewitz
MHHukiewitz previously approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@MHHukiewitz MHHukiewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we do not have a huge following on macOS and 3.11 is a reasonably recent Python release, the limitation should be ok. Should be mentioned though somewhere in the docs.

MHHukiewitz
MHHukiewitz approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@MHHukiewitz MHHukiewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MHHukiewitz MHHukiewitz merged commit 4f25ead into aleph-im:main Nov 8, 2023
10 checks passed
@MHHukiewitz MHHukiewitz mentioned this pull request Nov 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MHHukiewitz MHHukiewitz MHHukiewitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1yam @MHHukiewitz