Fix workflow triggers for Forked-Repo-PRs #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MHHukiewitz
force-pushed
the
mhh-trigger-workflows-on-forked-branches
branch
from
54367aa to
16a1e0d
Compare
|
We should run CI on all branches and Pull Requests. What about using this ? |
Won't this cause the CI to trigger on every push on every branch, even without PR in place? Thought it would be important to save on unnecessary GH actions usage |
…a PR was created from a forked repo Solution: Trigger all the workflows on direct pushes to main and on any PR to main
MHHukiewitz
force-pushed
the
mhh-trigger-workflows-on-forked-branches
branch
from
16a1e0d to
5d7c602
Compare
|
Good point. The main thing that consumes our CI usage is the replication due to the matrix of versions. We should run:
|
…; trigger code-quality on every push To reduce used compute time on action execution
hoh
reviewed
Oct 25, 2023
hoh
approved these changes
Oct 25, 2023
hoh
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: build-wheels.yml and pytest-docker.yml would not trigger if a PR was created from a forked repo.
Solution: Trigger all the workflows on direct pushes to main and on any PR to main.
Indication comes from #69 and #47, which were both PRs that did not trigger all workflows and both were attempted merges from 1yam's forked repo.