Add support for signing messages using LedgerHQ wallet on Ethereum #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoh
force-pushed
the
hoh-ledger-eth
branch
2 times, most recently
from
558d7cc to
3bc113c
Compare
Users could not use Ledger hardware wallets to sign messages using an Ethereum key. The command / response scheme used by Ledger to address the device is similar to the ISO/IEC 7816-4 smartcard protocol. Each command / response packet is called an APDU (application protocol data unit). Each APDU is specific to Ledger application, that adds the support for a chain or functionality. Solution: Use the Ledgereth library to send the Ethereum APDUs via ledgerblue.
odesenfans
requested changes
Aug 22, 2023
Co-authored-by: Olivier Desenfans <desenfans.olivier@gmail.com>
odesenfans
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to use private keys stored on a hardware wallet to sign messages would greatly enhance the security of the network, especially since messages can be amended and the virtual machines will potentially have many side effects.
The command / response scheme used by LedgerHQ to address the device is similar to the ISO/IEC 7816-4 smartcard protocol. Each command / response packet is called an APDU (application protocol data unit).
Each APDU is specific to Ledger application, that adds the support for a chain or functionality.
The library ledgereth implements the LedgerHQ ADPU for the Ethereum application.
This branch adds support in the SDK.
Usage:
Related to aleph-im/aleph-client#13